Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snow upgrade bugs encountered during upgrade from beta #2773

Merged
merged 5 commits into from
Jul 21, 2022
Merged

Fix snow upgrade bugs encountered during upgrade from beta #2773

merged 5 commits into from
Jul 21, 2022

Conversation

jiayiwang7
Copy link
Member

Issue #, if available:

#1106

Description of changes:

  • Support snow upgrade from beta with different CAPI objects naming format
  • Add ChangeDiff to upgrade CAPAS provider during components upgrade

Testing (if applicable):

  • Unit tests
  • Manually upgrade snow cluster from beta to latest

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jiayiwang7 jiayiwang7 requested a review from g-gaston July 20, 2022 20:50
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #2773 (b1954ea) into main (fe9290a) will increase coverage by 0.07%.
The diff coverage is 96.87%.

@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
+ Coverage   59.67%   59.74%   +0.07%     
==========================================
  Files         318      318              
  Lines       26068    26074       +6     
==========================================
+ Hits        15556    15579      +23     
+ Misses       9200     9188      -12     
+ Partials     1312     1307       -5
Impacted Files Coverage Δ
pkg/executables/clusterctl.go 70.48% <ø> (ø)
pkg/providers/snow/snow.go 58.75% <88.88%> (+3.19%) ⬆️
pkg/clusterapi/name.go 92.30% <100.00%> (+1.68%) ⬆️
pkg/providers/snow/objects.go 94.33% <100.00%> (+12.44%) ⬆️
controllers/resource/fetcher.go 40.35% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9290a...b1954ea. Read the comment docs.

@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2022
g-gaston
g-gaston reviewed Jul 21, 2022
View reviewed changes
pkg/clusterapi/name.go Outdated Show resolved Hide resolved
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 83e9ef5 into aws:main Jul 21, 2022
@jiayiwang7 jiayiwang7 deleted the snow-name branch July 25, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-gaston g-gaston g-gaston approved these changes

Assignees

@g-gaston g-gaston

Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiayiwang7 @eks-distro-bot @g-gaston