Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Move default connection generation in to server endpoint #507

Open
Tracked by #504
kmcginnes opened this issue Jul 25, 2024 · 0 comments
Open
Tracked by #504

[Task] Move default connection generation in to server endpoint #507

kmcginnes opened this issue Jul 25, 2024 · 0 comments
Assignees

Comments

@kmcginnes
Copy link
Collaborator

kmcginnes commented Jul 25, 2024

Currently, the default connection is configured in a myriad of ways.

  • Environment values set at docker run time
  • Environment values set in .env file
  • A config.json file that sets environment values

Then a Bash script interprets all of these options and generates a defaultConnection.json file. That file is then served as a static file by the /defaultConnection endpoint in Express.

Instead, I propose simplifying the approach a bit. The /defaultConnection endpoint can read the environment values, validate them, and generate the proper JSON object to send to the client. This removes complex and brittle Bash code to parse and manipulate JSON files and provides an easier path to testing the logic. It also allows for better defaults and fallback values.

@kmcginnes kmcginnes added this to the Release 1.9.0 milestone Jul 25, 2024
@kmcginnes kmcginnes self-assigned this Jul 25, 2024
@kmcginnes kmcginnes changed the title [Task] Move default config generation in to server endpoint [Task] Move default connection generation in to server endpoint Jul 30, 2024
@kmcginnes kmcginnes mentioned this issue Jul 30, 2024
14 tasks
@kmcginnes kmcginnes removed this from the Release 1.12.0 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant