Skip to content

Commit

Permalink
feat: configure engines with node >= 10.3.0 (#795)
Browse files Browse the repository at this point in the history
* feat: configure `engines` with `node >= 10.0.0`

As `node 8` is becoming EOL soon, we're upgrading the baseline `node`
version requirement from `>= 8.10.0` to `>= 10.0.0`. At this point, the
code generation is not affected, but this our first signal to consumers
that they need to upgrade their runtimes and/or codebases.

Additionally, normalized the order of fields in the `package.json` files
to make it nicer for people to work in the mono-repo.

Related to #794

* fix broken tests, bump minimal node to 10.3.0

* Update CONTRIBUTING.md
  • Loading branch information
RomainMuller authored and mergify[bot] committed Sep 19, 2019
1 parent 7d5d104 commit 6164b6b
Show file tree
Hide file tree
Showing 40 changed files with 547 additions and 376 deletions.
37 changes: 22 additions & 15 deletions packages/codemaker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,23 @@
"name": "codemaker",
"version": "0.17.0",
"description": "A tiny utility for generating source code",
"license": "Apache-2.0",
"author": {
"name": "Amazon Web Services",
"url": "https://aws.amazon.com"
},
"homepage": "https://github.com/aws/jsii",
"bugs": {
"url": "https://github.com/aws/jsii/issues"
},
"repository": {
"type": "git",
"url": "https://github.com/aws/jsii.git",
"directory": "packages/codemaker"
},
"engines": {
"node": ">= 10.3.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
"scripts": {
Expand All @@ -11,6 +28,11 @@
"test": "jest",
"package": "rm -fr dist/js && mkdir -p dist/js && mv $(npm pack) dist/js"
},
"dependencies": {
"camelcase": "^5.3.1",
"decamelize": "^1.2.0",
"fs-extra": "^8.1.0"
},
"devDependencies": {
"@types/decamelize": "^1.2.0",
"@types/fs-extra": "^8.0.0",
Expand All @@ -21,11 +43,6 @@
"jest": "^24.9.0",
"typescript": "~3.6.3"
},
"dependencies": {
"camelcase": "^5.3.1",
"decamelize": "^1.2.0",
"fs-extra": "^8.1.0"
},
"jest": {
"collectCoverage": true,
"collectCoverageFrom": [
Expand All @@ -47,15 +64,5 @@
"testMatch": [
"**/?(*.)+(spec|test).js"
]
},
"author": {
"name": "Amazon Web Services",
"url": "https://aws.amazon.com"
},
"license": "Apache-2.0",
"repository": {
"type": "git",
"url": "https://github.com/aws/jsii.git",
"directory": "packages/codemaker"
}
}
28 changes: 18 additions & 10 deletions packages/jsii-build-tools/package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,25 @@
{
"name": "jsii-build-tools",
"version": "0.17.0",
"description": "Internal repository-level tools",
"private": true,
"description": "Internal repository-level tools",
"license": "Apache-2.0",
"author": {
"name": "Amazon Web Services",
"url": "https://aws.amazon.com"
},
"homepage": "https://github.com/aws/jsii",
"bugs": {
"url": "https://github.com/aws/jsii/issues"
},
"repository": {
"type": "git",
"url": "https://github.com/aws/jsii.git",
"directory": "packages/jsii-build-tools"
},
"engines": {
"node": ">= 10.3.0"
},
"bin": {
"diff-test": "bin/diff-test",
"package-js": "bin/package-js",
Expand All @@ -13,14 +30,5 @@
},
"scripts": {
"build": "chmod +x bin/*"
},
"author": {
"name": "Amazon Web Services",
"url": "https://aws.amazon.com"
},
"license": "Apache-2.0",
"repository": {
"type": "git",
"url": "https://github.com/aws/jsii.git"
}
}
46 changes: 27 additions & 19 deletions packages/jsii-calc-base-of-base/package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,36 @@
{
"name": "@scope/jsii-calc-base-of-base",
"version": "0.17.0",
"private": true,
"description": "An example transitive dependency for jsii-calc.",
"license": "Apache-2.0",
"author": {
"name": "Amazon Web Services",
"url": "https://aws.amazon.com",
"organization": true
},
"homepage": "https://github.com/aws/jsii",
"bugs": {
"url": "https://github.com/aws/jsii/issues"
},
"repository": {
"type": "git",
"url": "https://github.com/aws/jsii.git",
"directory": "packages/jsii-calc-base-of-base"
},
"engines": {
"node": ">= 10.3.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
"private": true,
"scripts": {
"build": "jsii",
"test": "diff-test test/assembly.jsii .jsii"
},
"devDependencies": {
"jsii": "^0.17.0",
"jsii-build-tools": "file:../jsii-build-tools"
},
"jsii": {
"outdir": "dist",
"targets": {
Expand All @@ -26,23 +52,5 @@
"sphinx": {}
},
"versionFormat": "short"
},
"scripts": {
"build": "jsii",
"test": "diff-test test/assembly.jsii .jsii"
},
"devDependencies": {
"jsii": "^0.17.0",
"jsii-build-tools": "file:../jsii-build-tools"
},
"author": {
"name": "Amazon Web Services",
"url": "https://aws.amazon.com",
"organization": true
},
"license": "Apache-2.0",
"repository": {
"type": "git",
"url": "https://github.com/aws/jsii.git"
}
}
5 changes: 3 additions & 2 deletions packages/jsii-calc-base-of-base/test/assembly.jsii
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@
"url": "https://aws.amazon.com"
},
"description": "An example transitive dependency for jsii-calc.",
"homepage": "https://github.com/aws/jsii.git",
"homepage": "https://github.com/aws/jsii",
"jsiiVersion": "0.17.0",
"license": "Apache-2.0",
"name": "@scope/jsii-calc-base-of-base",
"repository": {
"directory": "packages/jsii-calc-base-of-base",
"type": "git",
"url": "https://github.com/aws/jsii.git"
},
Expand Down Expand Up @@ -111,5 +112,5 @@
}
},
"version": "0.17.0",
"fingerprint": "DqwNq9h/I55u0SJmn4804sgX3QdJRlvZtK1bdBrZsdA="
"fingerprint": "yqiCTEwufvpRvUJWXKok91vl3nOo7pVkbTPYM2LMs0A="
}
58 changes: 33 additions & 25 deletions packages/jsii-calc-base/package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,42 @@
{
"name": "@scope/jsii-calc-base",
"version": "0.17.0",
"private": true,
"description": "An example direct dependency for jsii-calc.",
"license": "Apache-2.0",
"author": {
"name": "Amazon Web Services",
"url": "https://aws.amazon.com",
"organization": true
},
"homepage": "https://github.com/aws/jsii",
"bugs": {
"url": "https://github.com/aws/jsii/issues"
},
"repository": {
"type": "git",
"url": "https://github.com/aws/jsii.git",
"directory": "packages/jsii-calc-base"
},
"engines": {
"node": ">= 10.3.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
"private": true,
"scripts": {
"build": "jsii",
"test": "diff-test test/assembly.jsii .jsii"
},
"dependencies": {
"@scope/jsii-calc-base-of-base": "file:../jsii-calc-base-of-base"
},
"peerDependencies": {
"@scope/jsii-calc-base-of-base": "file:../jsii-calc-base-of-base"
},
"devDependencies": {
"jsii": "^0.17.0",
"jsii-build-tools": "file:../jsii-build-tools"
},
"jsii": {
"outdir": "dist",
"targets": {
Expand All @@ -26,29 +58,5 @@
"sphinx": {}
},
"versionFormat": "short"
},
"scripts": {
"build": "jsii",
"test": "diff-test test/assembly.jsii .jsii"
},
"devDependencies": {
"jsii": "^0.17.0",
"jsii-build-tools": "file:../jsii-build-tools"
},
"dependencies": {
"@scope/jsii-calc-base-of-base": "file:../jsii-calc-base-of-base"
},
"peerDependencies": {
"@scope/jsii-calc-base-of-base": "file:../jsii-calc-base-of-base"
},
"author": {
"name": "Amazon Web Services",
"url": "https://aws.amazon.com",
"organization": true
},
"license": "Apache-2.0",
"repository": {
"type": "git",
"url": "https://github.com/aws/jsii.git"
}
}
5 changes: 3 additions & 2 deletions packages/jsii-calc-base/test/assembly.jsii
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,12 @@
}
},
"description": "An example direct dependency for jsii-calc.",
"homepage": "https://github.com/aws/jsii.git",
"homepage": "https://github.com/aws/jsii",
"jsiiVersion": "0.17.0",
"license": "Apache-2.0",
"name": "@scope/jsii-calc-base",
"repository": {
"directory": "packages/jsii-calc-base",
"type": "git",
"url": "https://github.com/aws/jsii.git"
},
Expand Down Expand Up @@ -176,5 +177,5 @@
}
},
"version": "0.17.0",
"fingerprint": "5fkhCkLN3NW/852/Ev17AgjuixpMt+Zq5QauaWnPt3s="
"fingerprint": "DDUI6HStojy2shnkcuy/OPKGon00z+H3UmkaetCe9l4="
}
16 changes: 12 additions & 4 deletions packages/jsii-calc-bundled/package.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,23 @@
{
"name": "jsii-calc-bundled",
"version": "0.17.0",
"main": "index.js",
"private": true,
"license": "Apache-2.0",
"author": {
"name": "Amazon Web Services",
"url": "https://aws.amazon.com"
},
"license": "Apache-2.0",
"homepage": "https://github.com/aws/jsii",
"bugs": {
"url": "https://github.com/aws/jsii/issues"
},
"repository": {
"type": "git",
"url": "https://github.com/aws/jsii.git"
}
"url": "https://github.com/aws/jsii.git",
"directory": "packages/jsii-calc-bundled"
},
"engines": {
"node": ">= 10.3.0"
},
"main": "index.js"
}
60 changes: 34 additions & 26 deletions packages/jsii-calc-lib/package.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,44 @@
{
"name": "@scope/jsii-calc-lib",
"version": "0.17.0",
"private": true,
"description": "A simple calcuator library built on JSII.",
"stability": "deprecated",
"deprecated": "Really just deprecated for shows...",
"stability": "deprecated",
"license": "Apache-2.0",
"author": {
"name": "Amazon Web Services",
"url": "https://aws.amazon.com",
"organization": true
},
"homepage": "https://github.com/aws/jsii",
"bugs": {
"url": "https://github.com/aws/jsii/issues"
},
"repository": {
"type": "git",
"url": "https://github.com/aws/jsii.git",
"directory": "packages/jsii-calc-lib"
},
"engines": {
"node": ">= 10.3.0"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",
"private": true,
"scripts": {
"build": "jsii",
"test": "diff-test test/assembly.jsii .jsii"
},
"dependencies": {
"@scope/jsii-calc-base": "file:../jsii-calc-base"
},
"peerDependencies": {
"@scope/jsii-calc-base": "file:../jsii-calc-base"
},
"devDependencies": {
"jsii": "^0.17.0",
"jsii-build-tools": "file:../jsii-build-tools"
},
"jsii": {
"outdir": "dist",
"targets": {
Expand All @@ -30,29 +62,5 @@
"sphinx": {}
},
"versionFormat": "short"
},
"scripts": {
"build": "jsii",
"test": "diff-test test/assembly.jsii .jsii"
},
"devDependencies": {
"jsii": "^0.17.0",
"jsii-build-tools": "file:../jsii-build-tools"
},
"dependencies": {
"@scope/jsii-calc-base": "file:../jsii-calc-base"
},
"peerDependencies": {
"@scope/jsii-calc-base": "file:../jsii-calc-base"
},
"author": {
"name": "Amazon Web Services",
"url": "https://aws.amazon.com",
"organization": true
},
"license": "Apache-2.0",
"repository": {
"type": "git",
"url": "https://github.com/aws/jsii.git"
}
}
Loading

0 comments on commit 6164b6b

Please sign in to comment.