Skip to content

Commit

Permalink
fix(jsii-pacmack): default to target directory mode (#363)
Browse files Browse the repository at this point in the history
Always generate to `$root/dist/TARGET`, even when only
generating one target. Don't double up on 'dotnet' name.

This behavior works better
for selectively building targets in a larger build that
expects certain naming conventions.
  • Loading branch information
rix0rrr authored Feb 14, 2019
1 parent 140aa4d commit 967d917
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/jsii-pacmak/bin/jsii-pacmak.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import { VERSION_DESC } from '../lib/version';
.option('force-subdirectory', {
type: 'boolean',
desc: 'force generation into a target-named subdirectory, even in single-target mode',
default: false
default: true,
})
.option('recurse', {
alias: 'R',
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii-pacmak/lib/targets/dotnet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default class Dotnet extends Target {

await this.copyFiles(
path.join(sourceDir, packageId, 'bin', 'Release'),
path.join(outDir, this.targetName));
outDir);
await fs.remove(path.join(outDir, 'netstandard2.0'));
}

Expand Down

0 comments on commit 967d917

Please sign in to comment.