fix(python): members named property results in invalid code #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a member is named `property`, it would start taking precedence over `builtings.property` when resolving the `@property` decorator. Fixed this by manually namespacing all `@<decorator>`, so local scope declarations cannot possibly shadow decorators. Fixes #1113
RomainMuller
force-pushed
the
rmuller/fix/1113
branch
from
e9fc0dc
to
0bb24ad
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
skinny85
approved these changes
Dec 11, 2019
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a member is named
property, it would start taking precedence overbuiltings.propertywhen resolving the@propertydecorator. Fixedthis by manually namespacing all
@<decorator>, so local scopedeclarations cannot possibly shadow decorators.
Fixes #1113
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.