fix(pacmak): label "External" stability as "Stable" #1633
Conversation
The distinction between "Stable" (checked stability) and "External" (unchecked stability) is lost on users, and honestly we shouldn't bother them with it. Treat them the same when generating code.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| /// <remarks> | ||
| /// <strong>Stability</strong>: Stable | ||
| /// </remarks> |
There was a problem hiding this comment.
Why is this now omitted? Sounds like a useful thing to put in the docs, no?
There was a problem hiding this comment.
It actually makes more sense to me to do the opposite: stable unless indicated otherwise. We already did that for Python and it makes sense.
It's also how every other API is documented. Nobody else just slathers on "stable" everywhere, they might note "deprected" or "experimental" as it applies.
| @@ -1,4 +1,4 @@ | |||
| ///!MATCH_ERROR: Symbol is re-exported under two distinct submodules (ns1 and ns2) | |||
| ///!MATCH_ERROR: Symbol is re-exported under two distinct submodules | |||
There was a problem hiding this comment.
Because on my machine this was breaking the build. The error message I got said (ns2 and ns1) (order different way around), and I did not want to fight with apparent nondeterminism.
There was a problem hiding this comment.
Ohhhh yeah makes sense!
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
The distinction between "Stable" (checked stability) and "External"
(unchecked stability) is lost on users, and honestly we shouldn't bother
them with it.
Treat them the same when generating code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.