fix(python): reference isomorphism is broken within __init__ #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the `__init__` of a class, reading `self` back from the JS process would result in a proxy object created for the parent type, instead of returning `self`. This is because the `JSIIMeta` metaclass only registered the instance in the rerefence map **after** the constructor had returned. This adds an additional registration point right after the `create` API returned from the kernel, making the reference available as early as it can possibly be known. Fixes aws/aws-cdk#8262
RomainMuller
added
bug
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Jun 9, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the
__init__of a class, readingselfback from the JSprocess would result in a proxy object created for the parent type,
instead of returning
self. This is because theJSIIMetametaclassonly registered the instance in the rerefence map after the
constructor had returned.
This adds an additional registration point right after the
createAPIreturned from the kernel, making the reference available as early as it
can possibly be known.
Fixes aws/aws-cdk#8262
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.