fix(rosetta): OOpsie -- couldn't find root file back on Windows #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
force-pushed
the
rmuller/fix-windows
branch
from
d9ff48d
to
043f857
Compare
RomainMuller
added
bug
The root file was located by comparing file paths in a way that was not adjusting path separators for Windows, and the result was inability to match normalized paths with Unix-style ones. This uses the `typescript.Program.getSourceFile` method instead, which locates the source file and handles the path matching correctly for us.
RomainMuller
force-pushed
the
rmuller/fix-windows
branch
from
33b959b
to
0c307c6
Compare
njlynch
reviewed
Jul 31, 2020
RomainMuller
force-pushed
the
rmuller/fix-windows
branch
from
69def24
to
df6c25c
Compare
njlynch
approved these changes
Jul 31, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root file was located by comparing file paths in a way that was not
adjusting path separators for Windows, and the result was inability to
match normalized paths with Unix-style ones.
This normalizes paths before attempting to match them, so that the match
can succeed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.