Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface with variable members is allowed #194

Closed
rix0rrr opened this issue Aug 22, 2018 · 1 comment
Closed

Interface with variable members is allowed #194

rix0rrr opened this issue Aug 22, 2018 · 1 comment
Labels
bug This issue is a bug. closed-for-staleness effort/medium Medium work item – a couple days of effort p2

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 22, 2018

jsii does not reject the following interface definition:

export interface Thingamajig {
    [key: string]: string
}

But what it generates for it is an empty interface, which is not correct:

    "@scope/lib.Thingamajig": {
      "assembly": "@scope/lib",
      "fqn": "@scope/lib.Thingamajig",
      "kind": "interface",
      "name": "Thingamajig"
    },

It should either reject this definition, or generate something sensible.

@SomayaB SomayaB added the feature-request A feature should be added or improved. label Nov 18, 2019
@SomayaB SomayaB added bug This issue is a bug. still-relevant? Checking to see if the issue is still relevant and removed feature-request A feature should be added or improved. labels Dec 19, 2019
@RomainMuller RomainMuller added p2 and removed still-relevant? Checking to see if the issue is still relevant labels Jan 7, 2020
@RomainMuller RomainMuller added the effort/medium Medium work item – a couple days of effort label Aug 11, 2020
@RomainMuller RomainMuller removed their assignment Jun 24, 2021
@github-actions
Copy link
Contributor

This issue has not received any attention in 2 years. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. closed-for-staleness effort/medium Medium work item – a couple days of effort p2
Projects
None yet
Development

No branches or pull requests

3 participants