Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsii should allow configuration of source and output directories #203

Closed
RomainMuller opened this issue Aug 28, 2018 · 6 comments
Closed

Comments

@RomainMuller
Copy link
Contributor

RomainMuller commented Aug 28, 2018

Currently, source directories are hard-coded to ['bin', 'lib', 'tests']. It may be desirable to allow configuring this.

We should also allow users to configure their typescript output directory. Some users (#213) may prefer their .js and .d.ts files not to be in the same place.

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 28, 2018

Oh please! While we're on this... do we actually need jsii to figure out source files? Can we not let tsc discover these itself from tsconfig.json?

I'm asking because right now, running tsc does not have the same effect as running jsii, and it's blocking my experimentations with the new TypeScript project references support (which is promising to improve our compile times by mucho!)

@eladb
Copy link
Contributor

eladb commented Aug 28, 2018

@rix0rrr so you are suggesting that the generated tsconfig.json will include a files section that corresponds to how jsii is using the compiler, correct?

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 28, 2018

Or "includes" pattern, much like jsii uses internally. tsc can also glob

@eladb eladb changed the title jsii should allow configuration of source directories jsii should allow configuration of source and output directories Sep 6, 2018
@hoegertn
Copy link
Contributor

hoegertn commented Jul 8, 2019

Any plans on this? I really like tsc to output the files to another folder instead of the lib folder.

@eladb
Copy link
Contributor

eladb commented Jul 8, 2019

No concrete plans but good intentions ;-). Would love a PR for this of course. Just haven’t had a time to prioritize

@hoegertn
Copy link
Contributor

hoegertn commented Jul 9, 2019

#593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants