fix(go): generate concrete structs for behavioral interfaces #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 17, 2020 08:22
Added runtime code gen for calls to jsii get/set apis. Changed order of args in runtime Get/Set functions to better match method invoke. Moved all property access to codegen to separate file.
Adds generation of empty structs for behavioral interfaces. These are to be used by the runtime so that methods that return behavioral interfaces have some known type that is able to be constructed and returned. These may be able to be made private (non-exported) though they may be referenced by other JSII modules that depend on them as necessitated by the runtime. Additionally, changes type signatures in places to always refer to the interface type of JSII classes, interfaces, and structs. This is required since JSII methods always return the interface implementation of complex types in order to resolve runtime reference values. In order for the returned values to be passed into other methods, the methods themselves must accept the interface type and not the concrete type.
Update runtime to properly handle Get/StaticGet calls from generated code. Updates jsii-calc-test to be runnable using `go test`.
Fixes bug in primitive type resolution for go type references.
SoManyHs
changed the title
RomainMuller
added
the
pr/do-not-merge
RomainMuller
approved these changes
Nov 18, 2020
MrArnoldPalmer
removed
the
pr/do-not-merge
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
SoManyHs
suggested changes
Nov 18, 2020
MrArnoldPalmer
added a commit
that referenced
this pull request
Nov 21, 2020
Renaming some args in go runtime as suggested in #2257.
MrArnoldPalmer
added a commit
that referenced
this pull request
Nov 24, 2020
Renaming some args in go runtime as suggested in #2257. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds generation of empty structs for behavioral interfaces. These are to
be used by the runtime so that methods that return behavioral interfaces
have some known type that is able to be constructed and returned. These
may be able to be made private (non-exported) though they may be
referenced by other JSII modules that depend on them as necessitated by
the runtime.
Additionally, changes type signatures in places to always refer to the
interface type of JSII classes, interfaces, and structs. This is
required since JSII methods always return the interface implementation
of complex types in order to resolve runtime reference values. In order
for the returned values to be passed into other methods, the methods
themselves must accept the interface type and not the concrete type.
Added runtime code gen for calls to jsii get/set apis. Changed order of
args in runtime Get/Set functions to better match method invoke.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.