fix(jsii): errors when invoking with a project root argument #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two bugs pertaining to invoking `jsii` with a project root argument (e.g: `jsii path/to/project`): - The positional argument was not correctly processed by `yargs` because it was not mentionned in the `command` description. - The project reference resolution code did not resolve relative paths from the correct starting point (`cwd` instead of the project root), resulting in compiler errors. This change fixes both.
MrArnoldPalmer
approved these changes
Dec 14, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two bugs pertaining to invoking
jsiiwith a project rootargument (e.g:
jsii path/to/project):yargsbecauseit was not mentionned in the
commanddescription.from the correct starting point (
cwdinstead of the project root),resulting in compiler errors.
This change fixes both.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.