feat(go): version file in the generated module directory #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
iliapolo
changed the title
eladb
pushed a commit
to aws/constructs
that referenced
this pull request
Jan 31, 2021
Use the latest version of jsii-release to publish go releases to https://github.com/aws/constructs-go (currently private). Until aws/jsii#2492 is resolved, add a build step which creates a `version` file in the go publish directory.
eladb
pushed a commit
to aws/constructs
that referenced
this pull request
Feb 1, 2021
Use the latest version of jsii-release to publish go releases to https://github.com/aws/constructs-go (currently private). Until aws/jsii#2492 is resolved, add a build step which creates a `version` file in the go publish directory.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
changed the title
RomainMuller
approved these changes
Feb 2, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since golang version isn't available anywhere inside the module, we embed a version file so that consumers can access the version.
This is needed for publishing go modules using
jsii-releasewithout the user having to supply the version externally.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.