fix(pacmak): TypeError when operating with Worker threads #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around isaacs/node-graceful-fs#204, where `graceful-fs` cannot be loaded from within `Worker` threads. Since the language generators are loaded in worker threads whenever they are available, they cannot use `fs-extra` which itself uses `graceful-fs`. This is hopefully a temporary measure, until isaacs/node-graceful-fs#205 is merged & released.
eladb
suggested changes
Feb 8, 2021
| @@ -46,8 +46,16 @@ export class Golang extends Target { | |||
|
|
|||
| // delete local.go.mod and local.go.sum from the output directory so it doesn't get published | |||
| const localGoSum = `${path.basename(localGoMod, '.mod')}.sum`; | |||
| await fs.remove(path.join(pkgDir, localGoMod)); | |||
| await fs.remove(path.join(pkgDir, localGoSum)); | |||
| await fs.unlink(path.join(pkgDir, localGoMod)).catch((err) => | |||
There was a problem hiding this comment.
Please extract to a helper function
| visit(dep), | ||
| ), | ||
| ), | ||
| ).then(() => void undefined); |
There was a problem hiding this comment.
Oh yeah you're right :P I thought I had... uh... a reason. but not.
| const lines = (await fs.readFile(goMod, 'utf-8')).split('\n'); | ||
| const lines = await fs | ||
| .readFile(goMod, 'utf8') | ||
| .then((text) => text.split('\n')); |
There was a problem hiding this comment.
Does this handle errors properly?
There was a problem hiding this comment.
Yep - .then has no catch handler, so it'd simply use the original rejection.
eladb
approved these changes
Feb 9, 2021
| await unlink(path.join(pkgDir, localGoMod)); | ||
| await unlink(path.join(pkgDir, localGoSum)); | ||
|
|
||
| async function unlink(file: string): Promise<void> { |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Merging (with squash)... |
RomainMuller
added a commit
that referenced
this pull request
Feb 9, 2021
)" This reverts commit 5822e48.
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around isaacs/node-graceful-fs#204, where
graceful-fscannot be loaded from within
Workerthreads. Since the languagegenerators are loaded in worker threads whenever they are available,
they cannot use
fs-extrawhich itself usesgraceful-fs.This is hopefully a temporary measure, until isaacs/node-graceful-fs#205
is merged & released.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.