fix(rosetta,pacmak): TypeError in node 10 with --experimental-worker #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 5822e48.
isaacs/node-graceful-fs#204 prevents `graceful-fs` (a dependency of `fs-extra`) from loading in a worker thread when using node < 12. The issue affects only version `4.2.5`, so pinning both `jsii-rosetta` and `jsii-pacmak` (both of which may use worker threads when available) to the last known good version: `4.2.4`, until a fixed release of `graceful-fs` is released.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isaacs/node-graceful-fs#204 prevents
graceful-fs(a dependency offs-extra) from loading in a worker thread when using node < 12. Theissue affects only version
4.2.5, so pinning bothjsii-rosettaandjsii-pacmak(both of which may use worker threads when available) tothe last known good version:
4.2.4, until a fixed release ofgraceful-fsis released.Note - this replaces the solution introduced in 5822e48 (#2550), which
turned out to not be complete enough (I mistakenly through the issue was
introduced by a recent change in our code, while it was triggered in other
places, actually due to a recent release of
graceful-fs).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.