Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Reconsider class code generation #2563

Closed
RomainMuller opened this issue Feb 11, 2021 · 2 comments
Closed

Go Reconsider class code generation #2563

RomainMuller opened this issue Feb 11, 2021 · 2 comments
Assignees
@RomainMuller
Labels
bug This issue is a bug. effort/medium Medium work item – a couple days of effort p1
Milestone
Go Sprint Feb 11 ...

Comments

@RomainMuller
Copy link
Contributor

🐛 Bug Report

In the current state of things, if a parent class adds a new member, child classes in other libraries would no longer compile until they are re-generated, which is problematic (it turns a non-breaking change in TS into a source-breaking change in go).

This is because we currently don't embed the parent type in the child classes, so they do not "inherit" parent members automatically.
@RomainMuller RomainMuller added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 11, 2021
@RomainMuller RomainMuller self-assigned this Feb 11, 2021
@RomainMuller RomainMuller added effort/medium Medium work item – a couple days of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 16, 2021
@RomainMuller
Copy link
Contributor Author

Updated aws/aws-cdk-rfcs#292 accordingly. Pending team review.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
bug This issue is a bug. effort/medium Medium work item – a couple days of effort p1
Projects
None yet
Milestone
Go Sprint Feb 11 - Mar 3 2020
Development

No branches or pull requests
1 participant
@RomainMuller