-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(go-runtime): enums are not encoded/decoded correctly #2585
Conversation
Enum values are represented in the jsii kernel as `{ "$jsii.enum": "fqn/member" }`, so we need to marshal/unmarshall them based on this encoding. Change the type registry to capture a mapping between FQN to enum member consts and type to enum FQNs.
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
Enum values are represented in the jsii kernel as
{ "$jsii.enum": "fqn/member" }
, so we need to marshal/unmarshall them based on this encoding.Change the type registry to capture a mapping between FQN to enum member consts and type to enum FQNs.
Fixes #2534
Co-authored-by: Romain Marcadier rmuller@amazon.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.