feat(go): preserve casing of enum member names #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in aws/aws-cdk-rfcs#292, using `_` to separate the constant name from the type name, and preserving the constant's casing results in an API that is slightly more readable, and less prone to namespace collisions.
RomainMuller
added
language/go
eladb
approved these changes
Feb 23, 2021
MrArnoldPalmer
approved these changes
Feb 24, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in aws/aws-cdk-rfcs#292, using
_to separate the constantname from the type name, and preserving the constant's casing results in
an API that is slightly more readable, and less prone to namespace
collisions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.