feat(go): represent jsii structs as go structs (only) #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As proposed in aws/aws-cdk-rfcs#292 (this is *Approach 4*), stop rendering go interfaces to represent jsii structs, and instead only emit a plain go struct with the flattened list of fields (own + all super interfaces). Made the necessary code changes to de-serialize structs returned by-reference by the `@jsii/kernel` by eagerly fecthing all properties. Also, implemented the option to offer convenience conversion functions to easily create a parent type from a child type.
RomainMuller
added
language/go
MrArnoldPalmer
requested changes
Feb 24, 2021
packages/jsii-pacmak/test/generated-code/__snapshots__/target-go.test.ts.snap
Show resolved
Hide resolved
RomainMuller
force-pushed
the
rmuller/go-no-struct-iface
branch
from
a8551a3 to
5a25183
Compare
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
approved these changes
Feb 25, 2021
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in aws/aws-cdk-rfcs#292 (this is Approach 4), stop
rendering go interfaces to represent jsii structs, and instead only emit
a plain go struct with the flattened list of fields (own + all super
interfaces).
Made the necessary code changes to de-serialize structs returned
by-reference by the
@jsii/kernelby eagerly fecthing all properties.Also, implemented the option to offer convenience conversion functions
to easily create a parent type from a child type.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.