feat(go): require go 1.16, use native embed #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
added
language/go
|
Note - this has a bootstrap paradox for the CodeBuild PR validation, as the |
Instead of generating code to build byte slices with the embedded assets, upgraded the baseline go requirement to go 1.16, and use the new native embed feature released as part of this go release. This includes the update to `jsii/superhain` to the correct go release, updates to the `.github/workflows/main.yml` workflow to ensure the correct go version is installed in PR validation builds, and the changes in `jsii-pacmak` and `@jsii/go-runtime` to leverage the feature. See: https://pkg.go.dev/embed
RomainMuller
force-pushed
the
rmuller/go-1.16
branch
from
b40c5c9
to
a51b06c
Compare
MrArnoldPalmer
approved these changes
Feb 25, 2021
| @@ -344,7 +348,9 @@ export class RootPackage extends Package { | |||
| importGoModules(code, toImport); | |||
|
|
|||
| code.line(); | |||
| code.line('var once sync.Once'); | |||
| code.line(`//go:embed ${tarballName(this.assembly)}`); | |||
There was a problem hiding this comment.
wow, go:embed is weird
# Conflicts: # packages/jsii-pacmak/lib/targets/go.ts # packages/jsii-pacmak/test/generated-code/__snapshots__/target-go.test.ts.snap
|
I have manually resolved the bootstrap paradox at this stage (I think) |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating code to build byte slices with the embedded
assets, upgraded the baseline go requirement to go 1.16, and use the new
native embed feature released as part of this go release.
This includes the update to
jsii/superhainto the correct go release,updates to the
.github/workflows/main.ymlworkflow to ensure thecorrect go version is installed in PR validation builds, and the changes
in
jsii-pacmakand@jsii/go-runtimeto leverage the feature.This makes the code easier to deal with by IDEs (the byte slices were
otherwise very large and caused IDEs to occasionally choke on them),
and removes the risk we make a mistake in generating the slices. It
also makes the generated code easier to troubleshoot, as the tarball
is present as-is, and can be inspected without additional hoop jumping.
See: https://pkg.go.dev/embed
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.