feat(pacmak): emit LICENSE file with SPDX license text, NOTICE file #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to properly attribute a license to the generated code, so it shows up on the godoc.org website, we must produce a `LICENSE` file with the appropriate content. See: https://pkg.go.dev/license-policy
RomainMuller
added
language/go
eladb
reviewed
Feb 24, 2021
packages/jsii-pacmak/test/generated-code/__snapshots__/target-go.test.ts.snap
Outdated
Show resolved
Hide resolved
eladb
approved these changes
Feb 24, 2021
RomainMuller
added
the
pr/do-not-merge
RomainMuller
changed the title
RomainMuller
changed the title
RomainMuller
removed
the
pr/do-not-merge
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to properly attribute a license to the generated code, so it
shows up on the godoc.org website, we must produce a
LICENSEfile withthe appropriate content.
We now copy the
LICENSEfile from the source package's root if oneexists, otherwise we attempt to generate one using the SPDX standard
license text.
We also copy the
NOTICEfile from the source package's root if oneexists (but there is no fallback here, as we cannot infer the contents
of it).
See: https://pkg.go.dev/license-policy
This was applied uniformly across all existing bindings.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.