Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): invalid generated code for classes a keyword name #2641

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Mar 3, 2021

Since these structs are all private, simply add a _jsiiProxy postfix to the name.

Fixes #2637


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Since these structs are all private, simply add a `_jsiiClass` postfix to the name.

Fixes #2637
@eladb eladb requested a review from RomainMuller March 3, 2021 09:22
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 3, 2021
Co-authored-by: Romain Marcadier <rmuller@amazon.com>
@eladb eladb requested a review from RomainMuller March 3, 2021 11:41
@eladb eladb changed the title fix(go): invalid generated output for a class with a keyword name fix(go): invalid generated code for classes a keyword name Mar 3, 2021
@eladb eladb merged commit 8668f13 into main Mar 3, 2021
@eladb eladb deleted the benisrae/mangle-class-struct branch March 3, 2021 13:24
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go: invalid generated output for a class named Default
2 participants