fix(dotnet): unable to pass 2d-array of interfaces #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a 2-dimensional array of interfaces was passed, the `InferType` function failed to account for interfaces, and failed instead of correctly returning the relevant type reference. Fixes aws/aws-cdk#12587
RomainMuller
force-pushed
the
rmuller/dotnet-bug
branch
from
d2a6df4
to
4e26a1a
Compare
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
|
@all-contributors add @ChristopheVico for bug |
|
I've put up a pull request to add @ChristopheVico! 🎉 |
eladb
approved these changes
Apr 1, 2021
| @@ -1512,5 +1512,18 @@ public override String Repeat(String word) | |||
| return word; | |||
| } | |||
| } | |||
|
|
|||
| [Fact(DisplayName = Prefix + nameof(ArrayOfInterfaces))] | |||
There was a problem hiding this comment.
Do we need to implement this in all other languages?
What about arrays of enums?
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a 2-dimensional array of interfaces was passed, the
InferTypefunction failed to account for interfaces, and failed instead of
correctly returning the relevant type reference.
Fixes aws/aws-cdk#12587
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.