Method Parameter Collision with Data Type property names not working for initializers

[dstufft]

It looks like the code added in #272 isn’t functioning in all cases. In particular, the Resource class in API Gateway has a constructor that is defined like:

constructor(parent: cdk.Construct, id: string, props: ResourceProps)

The ResourceProps interface is defined as:

export interface ResourceProps extends ResourceOptions {
  parent: IRestApiResource;
  pathPart: string;
}

Which means that when lifting the ResourceProps into keyword arguments, we’re attempting to generate a method signature like:

def __init__(self, parent: cdk.Construct, id: str, *, parent: IRestApiResource, pathPath: str) -> None

Which does not work, because there are two parameters named parent (which was the issue that #272 was looking to solve in the first place).

I’m guessing that because the original PR was touching only code inside of a _visitMethod method, that there is somewhere else this check needs to be added to handle initializer methods as well as regular methods— that’s just a guess though.