feat(superchain): arm64 support #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing ARM64 support for the `jsii/superchain` docker image using the multi-arch capabilities of `docker buildx`. This prompted a couple of changes in the image, which should be fine for the majority of use-cases, but is a breaking change in certain edge cases... The new image is based off `debian:10-slim`, as unfortunately, binary distributions of some of the image contents are not available for ARM64 platform on the RHEL/CentOS-based distributions (which `amazonlinux:2` is). This means packages now get installed from `apt` instead of `yum`. Image testing (by building `jsii` within the image) is now part of the image build process itself, instead of being separated, as this allows testing on all supported architectures (which is otherwise somewhat more difficult to achieve). BREAKING CHANGE: the `jsii/superchain` image is no longer based off `amazonlinux:2`, and instead is based off `debian:10-slim`. This means `yum` is no longer to be used for installing packages -- `apt-get` should be used instead.
RomainMuller
force-pushed
the
rmuller/superchain-arm64
branch
from
cd415a5 to
40ce9f4
Compare
RomainMuller
force-pushed
the
rmuller/superchain-arm64
branch
from
40ce9f4 to
9772aac
Compare
RomainMuller
force-pushed
the
rmuller/superchain-arm64
branch
from
61e1c68 to
e1ac54a
Compare
RomainMuller
force-pushed
the
rmuller/superchain-arm64
branch
from
62b8b78 to
fb7aef8
Compare
RomainMuller
force-pushed
the
rmuller/superchain-arm64
branch
from
15e1928 to
1fc61c1
Compare
RomainMuller
force-pushed
the
rmuller/superchain-arm64
branch
from
1fc61c1 to
188aa51
Compare
Chriscbr
reviewed
Aug 12, 2021
RomainMuller
force-pushed
the
rmuller/superchain-arm64
branch
from
f3e14ef to
25987e8
Compare
RomainMuller
force-pushed
the
rmuller/superchain-arm64
branch
from
2ac1aec to
2dc5322
Compare
RomainMuller
force-pushed
the
rmuller/superchain-arm64
branch
from
5bba56c to
967b158
Compare
RomainMuller
force-pushed
the
rmuller/superchain-arm64
branch
from
47f8060 to
2c42d1f
Compare
eladb
approved these changes
Aug 16, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing ARM64 support for the
jsii/superchaindocker image usingthe multi-arch capabilities of
docker buildx. This prompted a coupleof changes in the image, which should be fine for the majority of
use-cases, but is a breaking change in certain edge cases... So this change
also changes the image tagging model, so that users are able to reliably
depend on a particular linux distribution ancestry (
debian:buster-slimbeing the only offered option at this moment).
The new image is based off
debian:10-slim, as unfortunately, binarydistributions of some of the image contents are not available for ARM64
platform on the RHEL/CentOS-based distributions (which
amazonlinux:2is). This means packages now get installed from
aptinstead ofyum.Image testing (by building
jsiiwithin the image) is now part of theimage build process itself, instead of being separated, as this allows
testing on all supported architectures (which is otherwise somewhat more
difficult to achieve).
BREAKING CHANGE: the
jsii/superchainimage tags:latest,:nightly,:node10and:node14are no longer maintained. Users should migrate tothe new debian-based tags starting with
:1-buster-slim.Fixes #2930
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.