fix(rosetta): correctly detect arguments typed as any
#3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try and resolve the containing function call. If it resolves, we know the `any` the typechecker is giving us is actually intended to be an `any`. If the containing call does not resolve, we'll treat it as an unknown type of an uncompiling sample, and assume there's a struct there. Fixes #3029.
nija-at
approved these changes
Oct 7, 2021
| // Search for the function's declaration and only if we can't find it, | ||
| // the type is actually unknown (otherwise it's a literal 'any'). | ||
| const call = findEnclosingCallExpression(node); | ||
| const signature = call ? context.typeChecker.getResolvedSignature(call) : undefined; |
There was a problem hiding this comment.
nit: I like to do this as
Suggested change
| const signature = call ? context.typeChecker.getResolvedSignature(call) : undefined; | |
| const signature = call && context.typeChecker.getResolvedSignature(call); |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try and resolve the containing function call. If it resolves, we
know the
anythe typechecker is giving us is actually intended tobe an
any.If the containing call does not resolve, we'll treat it as an unknown
type of an uncompiling sample, and assume there's a struct there.
Fixes #3029.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.