fix(rosetta): support declare statements
#3044
Conversation
`declare` statements are an ideal way to signify that you expect certain variables of certain types to already exist. Add support for them to Rosetta.
| @@ -0,0 +1 @@ | |||
| Type variable; | |||
There was a problem hiding this comment.
Does this have the same meaning? In C# and Java it seems like declare becomes a variable definition instead of just a declaration. Am I missing something?
There was a problem hiding this comment.
What's the alternative though? The declare statement itself does not exist. I thought translating to a variable declaration makes it nice and clear that this variable should exist, that it comes from somewhere, and what the type is.
Ideally in a hypothetical future where we have more control over the output rendering, that type name will be clickable to send you to the type's page to get an instantiation of it.
There was a problem hiding this comment.
This looks to be a variable declaration. Maybe the word Type threw you off. Could change it to MyType and make unambiguous.
There was a problem hiding this comment.
Could be a comment like in Python.
But I guess a type definition without an assignment is clear enough.
| @@ -0,0 +1 @@ | |||
| Type variable; | |||
There was a problem hiding this comment.
This looks to be a variable declaration. Maybe the word Type threw you off. Could change it to MyType and make unambiguous.
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
) (The diff of this PR will clean up after #3044 has been merged) The error was in conflating "detecting a map type but not knowing what the element type was" and "not detecting a map type" (these cases could not be distinguished because both would result in `undefined`). Also remove an unnecessary argument to `keyValueObjectLiteralExpression`. Fixes #3026, fixes #3027. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
declarestatements are an ideal way to signify that you expectcertain variables of certain types to already exist.
Add support for them to Rosetta.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.