Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rosetta): allow only property assignments in object literals #3065

Merged
merged 7 commits into from
Oct 13, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 13, 2021

We'll report on anything else that JavaScript allows you to do (methods, getters, etc).

Fixes #3061.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

It cannot be translated, and so should be written as an `if` statement
or a ternary.

Fixes #3053.
We'll report on anything else that JavaScript allows you to do (methods, getters, etc).

Fixes #3061.
@rix0rrr rix0rrr requested a review from a team October 13, 2021 11:22
@rix0rrr rix0rrr self-assigned this Oct 13, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 13, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Oct 13, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2021

Merging (with squash)...

@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2021

Merging (with squash)...

@mergify mergify bot merged commit c783ab7 into main Oct 13, 2021
@mergify mergify bot deleted the huijbers/disallow-object-craziness branch October 13, 2021 16:34
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(rosetta): inline functions in objects should be disallowed
2 participants