fix(jsii): unexpected deprecated warnings when a deprecated interface is extended #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is extended It is common in the AWS CDK for non-deprecated interfaces to extend deprecated interfaces. Currently, when this occurs and the non-deprecated subclass is referenced, a warning is generated notifying the deprecation of its superclass. Modify the implementation such that the warning is produced only when a property of the deprecated interface is referenced. In the case when a deprecated interface with no required properties is used without any of its properties set, a warning will not be generated. This should occur rarely and the trade off is acceptable. fixes #3111
otaviomacedo
approved these changes
Nov 2, 2021
rix0rrr
added
pr/do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common in the AWS CDK for non-deprecated interfaces to extend
deprecated interfaces.
Currently, when this occurs and the non-deprecated subclass is
referenced, a warning is generated notifying the deprecation of its
superclass.
Modify the implementation such that the warning is produced only when
a property of the deprecated interface is referenced.
In the case when a deprecated interface with no required properties is
used without any of its properties set, a warning will not be generated.
This should occur rarely and the trade off is acceptable.
fixes #3111
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.