fix(rosetta): infuse creates untranslated examples
#3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `infuse` feature replicates examples from READMEs to types. However, because of caching, example locations have become part of their identifying key. Because an example has moved to a different location, it now has a different key, and because that key is not in the tablet yet the example will count as untranslated (requiring live conversion during `pacmak` time, and increasing the pack time). When we copy an example to a different type, also create a copy at the new type location in the tablet, so that it will count as pretranslated.
kaizencc
approved these changes
Nov 5, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
infusefeature replicates examples from READMEs to types.However, because of caching, example locations have become part of their
identifying key. Because an example has moved to a different location,
it now has a different key, and because that key is not in the tablet
yet the example will count as untranslated (requiring live conversion
during
pacmaktime, and increasing the pack time).When we copy an example to a different type, also create a copy at
the new type location in the tablet, so that it will count as
pretranslated.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.