-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rosetta): classes are not correctly identified if package uses an outDir #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
requested changes
Dec 6, 2021
rix0rrr
approved these changes
Dec 7, 2021
@@ -92,3 +92,85 @@ test('Submodules also have symbol identifiers', async () => { | |||
'index:cookie', | |||
); | |||
}); | |||
|
|||
describe(normalizePath, () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! That is hot damn thorough! 😅
rix0rrr
changed the title
feat(rosetta): extract finds fqns of snippets when given an outDir and/or rootDir
fix(rosetta): classes are not correctly identified if package uses an outDir
Dec 7, 2021
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
Oh no, issue on Windows:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rosetta extract
breaks down when a project structure includesoutDir
orrootDir
in thetsconfig
file. Given such a project structure,extract
may find symbolIds that look likeoutDir/index:ClassA
orrootDir/index:ClassA
. Since the jsii assembly is created from the source files in therootDir
,rootDir/index:ClassA
is the symbolId we want. So if theoutDir
is specified, we swap it with the specifiedrootDir
(and ifrootDir
is not specified, we guess at it the same way node does). This ensures thatrosetta extract
is structure agnostic.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.