feat: rosetta go support #3376
Merged
feat: rosetta go support #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Go renderer for jsii-rosetta to support translating documentations snippets to Go.
- Ouptut tab-idented go code - Basic support for "newExpression" - go maps are emitted with one item per line, with consistent spacing - Comment examples pass
RomainMuller
force-pushed
the
feat/rosetta-go-support
branch
from
0dc10e4
to
d60117d
Compare
rix0rrr
approved these changes
Feb 24, 2022
| @@ -87,7 +93,7 @@ for (const typeScriptTest of typeScriptTests) { | |||
| const expected = fs.readFileSync(languageFile, { encoding: 'utf-8' }); | |||
| try { | |||
| const translation = translator.renderUsing(visitorFactory.createVisitor()); | |||
| expect(stripEmptyLines(translation)).toEqual(stripEmptyLines(stripCommonWhitespace(expected))); | |||
| expect(stripEmptyLines(translation)).toBe(stripEmptyLines(stripCommonWhitespace(expected))); | |||
There was a problem hiding this comment.
It's a slightly faster comparison (=== for toBe versus == for toEquals), semantically equivalent for strings :)
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Go renderer for jsii-rosetta to support translating documentations
snippets to Go.
Fixes #2439
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.