feat(rosetta): tablets can be compressed #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
commented
Jul 7, 2022
RomainMuller
reviewed
Jul 8, 2022
RomainMuller
previously approved these changes
Jul 11, 2022
mergify
bot
dismissed
RomainMuller’s stale review
Pull request has been modified.
MrArnoldPalmer
approved these changes
Jul 11, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
mergify bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
…es (#3670) Unfortunately, #3652 was half-baked and this PR serves to finish handling tablet compression. It introduces the following: - `compress-cache` cli option so that you can use a compressed cache file - update to all usages of `languageTablet.save()` to explicitly pass the compress flag - `languageTablet.compressedSource`, which is set when we load from a compressed source, so that we can remember to save as a compressed source. - `loadAllDefaultTablets` now handles compressed default tablets. - a far more encompassing set of unit tests for the above features --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
yarn rosetta extract --compress-tabletThis should reduce the
.jsii.tabl.jsonsize by about 90%.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.