fix(python): unable to override methods with keyword arguments #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback logic in the jsii runtime library for Python was incorrectly passing keyword arguments to Python implementations, forwarding a struct instance as-is instead of destructuring it into a keyword arguments mapping. Using `inspect.signature()`, detect the presence of keyword arguments on the callback target, and destructure the struct as relevant. Fixes #3656
Naumel
reviewed
Aug 2, 2022
Comment on lines
+1423
to
+1431
| }, | ||
| { | ||
| "login": "gshpychka", | ||
| "name": "Glib Shpychka", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/23005347?v=4", | ||
| "profile": "https://github.com/gshpychka", | ||
| "contributions": [ | ||
| "bug" | ||
| ] |
There was a problem hiding this comment.
0.02$: This change seems unrelated to the fix
There was a problem hiding this comment.
This is the record for the individual who's reported this bug... Need I submit 2 separate PRs?
Naumel
approved these changes
Aug 2, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback logic in the jsii runtime library for Python was
incorrectly passing keyword arguments to Python implementations,
forwarding a struct instance as-is instead of destructuring it into a
keyword arguments mapping.
Using
inspect.signature(), detect the presence of keyword arguments onthe callback target, and destructure the struct as relevant.
Fixes #3656
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.