Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependence on global "node" executable #3725

Closed
2 tasks
pauldraper opened this issue Aug 28, 2022 · 4 comments
Closed
2 tasks

Remove dependence on global "node" executable #3725

pauldraper opened this issue Aug 28, 2022 · 4 comments
Labels
feature-request A feature should be added or improved.

Comments

@pauldraper
Copy link

Describe the feature

This project relies on a "node" executable on PATH, regardless of what node.js executable is used to run cdk.

https://github.com/aws/jsii/blob/main/packages/%40jsii/python-runtime/src/jsii/_kernel/providers/process.py#L251

Use Case

Node.js may not be installed globally. Or perhaps it is installed, but not named "node." E.g. node18, node19 similar to python2, python3.

Proposed Solution

Use an env var, like

NODE_RUNTIME=/usr/local/bin/node18

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

Environment details (OS name and version, etc.)
@pauldraper pauldraper added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 28, 2022
@mrgrain
Copy link
Contributor

mrgrain commented Apr 9, 2024

Resolved by #4024

@mrgrain mrgrain closed this as completed Apr 9, 2024
@mrgrain mrgrain removed the needs-triage This issue or PR still needs to be triaged. label Apr 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

@pauldraper
Copy link
Author

Thank you!

@mrgrain
Copy link
Contributor

mrgrain commented Apr 10, 2024 •
edited
Loading

No worries. It's been resolved for ages. Apologies for missing this ticket. Let me know if that works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrgrain @pauldraper