Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): bin script python support, test argument passing #3762

Merged
merged 11 commits into from
Sep 23, 2022
Merged

fix(python): bin script python support, test argument passing #3762

merged 11 commits into from
Sep 23, 2022

Conversation

jmalins
Copy link
Contributor

@jmalins jmalins commented Sep 21, 2022

Corrects multiple issues with running bin scripts from python.

These were discovered in the context of this projen issue: projen/projen#2103

Additionally, adds more robust test coverage of passing arguments to bin scripts.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmalins jmalins marked this pull request as ready for review September 21, 2022 17:37
@jmalins
Copy link
Contributor Author

jmalins commented Sep 21, 2022

Updated: Please disregard. TIL, tmpfs disables execute by default.


The tests are currently failing due to the jsii-calc/bin/run not being executable in the extracted tarball.

status: 126
stderr: "/bin/sh: 1: /tmp/jsii-kernel-4QI5As/node_modules/jsii-calc/bin/run: Permission denied"

I'm still trying to troubleshoot this. Running npm pack manually produces a tarball with correct -rwxr-xr-x permissions.

@RomainMuller RomainMuller self-assigned this Sep 22, 2022
@jmalins
Copy link
Contributor Author

jmalins commented Sep 23, 2022

Hi @RomainMuller, is it acceptable to leave Windows bin invoke functionality partially implemented? It appears that is the current state of jsii-pacmak, as it doesn't generate executables scripts for Windows, which would need to be added.

Other than that, I believe this PR is ready.

@RomainMuller
Copy link
Contributor

@jmalins if that is currently broken I'm not going to demand you fix it of course 😅

RomainMuller
RomainMuller previously approved these changes Sep 23, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Sep 23, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

Merging (with squash)...

@mergify mergify bot dismissed RomainMuller’s stale review September 23, 2022 14:53

Pull request has been modified.

Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

Merging (with squash)...

@mergify mergify bot merged commit 0cf5008 into aws:main Sep 23, 2022
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Sep 23, 2022
@jmalins jmalins deleted the bin-script-invoke-args branch September 23, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants