-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python): bin script python support, test argument passing #3762
Conversation
Updated: Please disregard. TIL, The tests are currently failing due to the status: 126
stderr: "/bin/sh: 1: /tmp/jsii-kernel-4QI5As/node_modules/jsii-calc/bin/run: Permission denied" I'm still trying to troubleshoot this. Running |
Hi @RomainMuller, is it acceptable to leave Windows bin invoke functionality partially implemented? It appears that is the current state of Other than that, I believe this PR is ready. |
@jmalins if that is currently broken I'm not going to demand you fix it of course 😅 |
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Merging (with squash)... |
Corrects multiple issues with running
bin
scripts from python.These were discovered in the context of this
projen
issue: projen/projen#2103Additionally, adds more robust test coverage of passing arguments to
bin
scripts.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.