fix(go): shorten file names for sub-packages #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a hard time updating the snapshots 🙈 Can someone help me out here? |
| ), | ||
| false, | ||
| ); | ||
| emit.call(this, join(this.directory, `${type.name}__checks.go`), false); |
There was a problem hiding this comment.
Does this not risk collisions if two namespaces have the same leaf type name?
There was a problem hiding this comment.
No, they are in nested folders
DanielMSchmidt
force-pushed
the
shorten-golang-file-names
branch
from
b278c77
to
d9aa9ba
Compare
DanielMSchmidt
force-pushed
the
shorten-golang-file-names
branch
from
d9aa9ba
to
5ff6c7b
Compare
RomainMuller
previously approved these changes
Feb 3, 2023
mergify
bot
dismissed
RomainMuller’s stale review
Pull request has been modified.
RomainMuller
approved these changes
Feb 3, 2023
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDKTF is running into build issues one some providers due to file names being too long for golang to handle: https://github.com/cdktf/cdktf-provider-googlebeta/actions/runs/4002506018/jobs/6869839656#step:8:11
This is my slightly naive try to get rid of a few characters (especially with long package names)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.