Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python - Some Dependencies Do Not Get Emitted #413

Closed
dstufft opened this issue Mar 28, 2019 · 2 comments
Closed

Python - Some Dependencies Do Not Get Emitted #413

dstufft opened this issue Mar 28, 2019 · 2 comments
Assignees
Labels
bug This issue is a bug. language/python Related to Python bindings

Comments

@dstufft
Copy link
Contributor

dstufft commented Mar 28, 2019

This might be a duplicate of #361.

Basically, when emitting dependency information the Python generator only cares about peer dependencies, however it appears that some items are dependencies but which are not currently marked as peer dependencies. This surfaces as a missing library at runtime like:

Traceback (most recent call last):
  File "app.py", line 2, in <module>
    from aws_cdk import (
  File "/Users/dstufft/projects/aws-cdk-examples/python/application-load-balancer/.env/lib/python3.7/site-packages/aws_cdk/aws_autoscaling/__init__.py", line 13, in <module>
    import aws_cdk.aws_autoscaling_common
ModuleNotFoundError: No module named 'aws_cdk.aws_autoscaling_common'

This can be worked around by simply manually installing the missing library (in the above case, aws-cdk.aws-autoscaling-common).

We need to determine if this just needs #361 to be resolved, and get that across the finish line, or if Python should look at more than just peer dependencies and if so, stop filtering to only peer dependencies.

@dstufft dstufft added bug This issue is a bug. language/python Related to Python bindings labels Mar 28, 2019
@RomainMuller
Copy link
Contributor

@dstufft - #361 has a PR available that you might want to test against.

@RomainMuller
Copy link
Contributor

#361 has now shipped, it is possible that the problem is gone!

@fulghum fulghum added the p0 label Apr 4, 2019
@RomainMuller RomainMuller added this to the Python Support milestone Aug 6, 2019
@eladb eladb removed the p0 label Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. language/python Related to Python bindings
Projects
None yet
Development

No branches or pull requests

4 participants