feat(jsii): allow specifying a deprecation message regardless of stability #4145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility Previously, `jsii` required the package's stability to be `deprecated` if there cas a `deprecated` message configured. This is however problematic when a `stable` package reaches End-of-Support and the maintainer wants to signal this in npmjs.com. Instead of failing, only log a warning to possibly raise awareness on an unintended configuration. Additionally - emit the `Development Status :: 7 - Inactive` trove classifier on packages with a `deprecated` message, even if their stability is not `deprecated`.
RomainMuller
added a commit
to aws/jsii-compiler
that referenced
this pull request
Jun 13, 2023
Previously, `jsii` required the package's stability to be `deprecated` if there cas a `deprecated` message configured. This is however problematic when a `stable` package reaches End-of-Support and the maintainer wants to signal this in npmjs.com. Instead of failing, only log a warning to possibly raise awareness on an unintended configuration. Foward-ports: aws/jsii#4145
rix0rrr
approved these changes
Jun 13, 2023
github-merge-queue bot
pushed a commit
to aws/jsii-compiler
that referenced
this pull request
Jun 13, 2023
…146) Previously, `jsii` required the package's stability to be `deprecated` if there cas a `deprecated` message configured. This is however problematic when a `stable` package reaches End-of-Support and the maintainer wants to signal this in npmjs.com. Instead of failing, only log a warning to possibly raise awareness on an unintended configuration. Foward-ports: aws/jsii#4145 --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
jsiirequired the package's stability to bedeprecatedif there cas adeprecatedmessage configured. This is however problematic when astablepackage reaches End-of-Support and the maintainer wants to signal this in npmjs.com.Instead of failing, only log a warning to possibly raise awareness on an unintended configuration.
Additionally - emit the
Development Status :: 7 - Inactivetrove classifier on packages with adeprecatedmessage, even if their stability is notdeprecated.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.