fix(pacmak): jsii-pacmak uses incompatible version of jsii-rosetta #4487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/feat/pacmak-can-use-any-rosetta
branch
from
2cd182e
to
fb25ceb
Compare
mrgrain
changed the title
mrgrain
changed the title
mrgrain
commented
Apr 25, 2024
.github/workflows/main.yml
Outdated
Comment on lines
426
to
428
| strategy: | ||
| matrix: | ||
| rosetta: ['1.x', '5.2.x', '5.3.x', '5.4.x'] |
There was a problem hiding this comment.
Unfortunately the workflow file is not codegen'd, so we will have to update this manually.
mrgrain
force-pushed
the
mrgrain/feat/pacmak-can-use-any-rosetta
branch
from
8a6d9e1
to
18237a1
Compare
rix0rrr
approved these changes
Apr 26, 2024
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4098
Previously jsii-pacmak depended on jsii-rosetta 1.x. This is problematic if a different version of the jsii compiler was used, because it introduced different versions of TypeScript into the project.
With this PR, the dependency is changed to a peer dependency. Thus allowing any compatible version jsii-rosetta to be used.
BREAKING CHANGE: jsii-pacmak now has a peer dependency on jsii-rosetta. Please ensure a version of jsii-rosetta matching your version of jsii is available. Most package managers install peer dependencies automatically and no change is required. However users of yarn v1 or npm v3 to v6 must install jsii-rosetta manually.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.