fix(jsii-pacmak): Python interfaces sometimes violate MRO #4973
+106
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Method Resolution Order (MRO) rules for Python state (in brief) that all classes and interfaces in an inheritance declaration must be listed subclass-before-superclass, and in the same order on all classes. `jsii-pacmak` was not guaranteeing order, leading to sometimes producing an order that violates MRO. Update `jsii-pacmak` to update base classes and sort them in the right order.
mrgrain
approved these changes
Nov 4, 2025
Contributor
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Contributor
|
Merging (with squash)... |
This was referenced Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Method Resolution Order (MRO) rules for Python state (in brief) that all classes and interfaces in an inheritance declaration must be listed subclass-before-superclass, and in the same order on all classes.
jsii-pacmakwas not guaranteeing order, leading to sometimes producing an order that violates MRO.Update
jsii-pacmakto update base classes and sort them in the right order.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.