Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dotnet): drop the useless I prefix for non datatype interfaces #728

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

assyadh
Copy link
Contributor

@assyadh assyadh commented Aug 21, 2019

Drop the useless I prefix for non datatype interfaces as they are guaranteed by jsii to start with I.

This removes a bunch of II* interfaces.

Updated the tests, and tested with the CDK successfully.

BREAKING CHANGE: names of .NET behavioral interfaces have changed (the duplicate prefix I was removed).

Fixes #109


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@assyadh assyadh requested review from costleya and a team as code owners August 21, 2019 20:07
@assyadh assyadh assigned assyadh and unassigned assyadh Aug 21, 2019
@assyadh assyadh added the language/dotnet Related to .NET bindings (C#, F#, ...) label Aug 21, 2019
@RomainMuller RomainMuller merged commit b9621f1 into master Aug 22, 2019
@RomainMuller RomainMuller deleted the hamzaad/drop-I-interface branch August 22, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/dotnet Related to .NET bindings (C#, F#, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a JSII interface has a name like IFoo, the generated .NET interface is named IIFoo
2 participants