fix(dotnet): allow down-casting to parent interface type #983
Conversation
Cast controls were too strict and prevented the framework from successfully down-casting an object reference to a parent interface of it's declared type; causing a cast error. The new code looks for class compatibility using the standard .NET primitives and successfully performs the requested cast. Fixes #982
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| <ItemGroup> | ||
| <ProjectReference Include="..\..\..\jsii-dotnet-runtime\src\Amazon.JSII.Runtime\Amazon.JSII.Runtime.csproj" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
where is this coming from and how come it wasn't required so far?
There was a problem hiding this comment.
So. I've added this because it makes working with the integration tests in an IDE much nicer... It isn't required per se, but ensures that the local source is used instead of what's in the symbols package (makes debugging more efficient, reduces cycle time because a single solution build gets all the work done, ...).
I routinely add this when I work in the kernel, and since this is not a published artifact, I figured I'd leave it in this time... Because it'd help everyone in this situation.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Added the mighty Python test (I swear that was always the plan, but I knew this was not a problem there, and I had to turn to other problems for a moment :D) |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Cast controls were too strict and prevented the framework from
successfully down-casting an object reference to a parent interface of
it's declared type; causing a cast error.
The new code looks for class compatibility using the standard .NET
primitives and successfully performs the requested cast.
Fixes #982
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.