Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsii should enforce consistent access modifiers between symbols and their overrides #99

Closed
mpiroc opened this issue Jul 24, 2018 · 2 comments
Closed

jsii should enforce consistent access modifiers between symbols and their overrides #99

mpiroc opened this issue Jul 24, 2018 · 2 comments

Comments

@mpiroc
Copy link
Contributor

mpiroc commented Jul 24, 2018 •
edited
Loading

In .NET, access modifiers must match exactly. So this is invalid:

class Foo {
    protected abstract void DoSomething();
}

class Bar : Foo {
    public void DoSomething() { }
}

When jsii detects inconsist access modifiers, it should report an error.
@mpiroc
Copy link
Contributor Author

mpiroc commented Jul 24, 2018

See aws/aws-cdk#392 for example.

@mpiroc mpiroc mentioned this issue Aug 2, 2018
Merged
@mpiroc
Copy link
Contributor Author

mpiroc commented Aug 11, 2018

This was fixed by #115.

@mpiroc mpiroc closed this as completed Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpiroc