Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to remove "name" tag or customize it dynamically? #3342

Closed
cep21 opened this issue Feb 2, 2023 · 4 comments · Fixed by #4611
Closed

How to remove "name" tag or customize it dynamically? #3342

cep21 opened this issue Feb 2, 2023 · 4 comments · Fixed by #4611
Assignees
Labels
feature New feature or request

Comments

@cep21
Copy link

cep21 commented Feb 2, 2023

Is an existing page relevant?

No response

What karpenter features are relevant?

labels and tags.

How should the docs be improved?

Rather than spin up ec2 instances with a static EC2 tag name of the provisioner, it would be really useful if the EC2 tag name matched the node's name, which is currently the private IP for us in EKS. Is this possible? It may require karpenter to update the name after the node is provisioned.

If it is not, is it possible to just not tag the node's name at all? We currently use datadog that automatically imports EC2 tags into metric tags, but aren't getting much use out of name since they all have the same name tag.

Thanks!

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@jonathan-innis jonathan-innis added feature New feature or request aws labels Feb 2, 2023
@jonathan-innis
Copy link
Contributor

If it is not, is it possible to just not tag the node's name at all?

If Karpenter had to tag the instance with something, what would you prefer it to be? We have this proposal that is in the works and one of the thoughts is to tag the instances that would be launched with the machine name, which we could know ahead of time.

@cep21
Copy link
Author

cep21 commented Feb 2, 2023

what would you prefer it to be

Whatever shows up when I type kubectl get nodes is my preference. I don't particularly care what the node names are, but do prefer the kubectl and EC2 UI match.

@pincher95
Copy link
Contributor

Or resource id would be also great

@ellistarn
Copy link
Contributor

Resource Based Naming aws/containers-roadmap#1723 (comment) causes node name and instance id to converge. EC2 name tag is another thing entirely. It's a bit redundant to have a name tag == instance id. The other challenge is that the instance id isn't known until the instance is created, so the tagging would have to happen later, creating reconciliation / atomicity challenges. Possible, just work to deal with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants