Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs opened by the github-actions bot don't trigger status checks #4525

Open
jonathan-innis opened this issue Aug 31, 2023 · 7 comments
Open
Assignees
Labels
automation Issues about the Karpenter's automation processes good-first-issue Good for newcomers operational-excellence

Comments

@jonathan-innis
Copy link
Contributor

jonathan-innis commented Aug 31, 2023

Description

Currently, if a PR is opened by the github-actions bot, status checks will just sit in an Expected state forever. We need to look into why this automation is broken.

Workaround

The current workaround is to push a new commit on the branch yourself or to close and re-open the PR to re-trigger the checks.

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@jonathan-innis jonathan-innis added good-first-issue Good for newcomers automation Issues about the Karpenter's automation processes labels Aug 31, 2023
@aman0408
Copy link
Contributor

aman0408 commented Sep 3, 2023

Can I work on this issue?

@aman0408
Copy link
Contributor

aman0408 commented Sep 3, 2023

This behviour is expected as described in the documentation

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.

@jonathan-innis
Copy link
Contributor Author

This behviour is expected

Good point. I wonder if there's a different way that we could trigger workflow runs so that we don't have to manually intervene every time one of these PRs is opened.

@aman0408
Copy link
Contributor

aman0408 commented Sep 7, 2023

@jonathan-innis can we use this workaround?
peter-evans/create-pull-request#48 (comment)

@jonathan-innis
Copy link
Contributor Author

jonathan-innis commented Sep 11, 2023

can we use this workaround

We need to check with our security team before we could take something like this into the project. Generally, long-term static credentials are frowned upon by security teams because they allow persistent access to the project if they are compromised. We might be able to get around the concern here if the scope of the token is only to open pull requests against the repo. I can check back here with the security team and see what they recommend here.

@jonathan-innis
Copy link
Contributor Author

@aman0408 Checking in here. Are you still planning to work on this one?

@aman0408
Copy link
Contributor

Yes @jonathan-innis . I have been busy since a couple of weeks but I should be able to make some progress in this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Issues about the Karpenter's automation processes good-first-issue Good for newcomers operational-excellence
Projects
None yet
Development

No branches or pull requests

3 participants