ci: remove exceptions for clippy (#2726)

* ci: remove exceptions for clippy

* fix inline format args

* fix inline format args

Author: WesleyRosenblum

.github/workflows/ci.yml

@@ -120,12 +120,7 @@ jobs:
       # TODO translate json reports to in-action warnings
       - name: Run cargo clippy
         run: |
-          # deriving Eq may break API compatibility so we disable it
-          # See https://github.com/rust-lang/rust-clippy/issues/9063
-          #
-          # manual_clamp will panic when min > max
-          # See https://github.com/rust-lang/rust-clippy/pull/10101
-          cargo clippy --all-features --all-targets --workspace -- -A clippy::derive_partial_eq_without_eq -A clippy::manual_clamp ${{ matrix.args }}
+          cargo clippy --all-features --all-targets --workspace -- ${{ matrix.args }}
 
   udeps:
     runs-on: ubuntu-latest
@@ -529,7 +524,7 @@ jobs:
 
       - name: lint
         working-directory: ${{ matrix.example }}
-        run: cargo clippy --all-features --all-targets -- -A clippy::manual_clamp -A clippy::uninlined_format_args -D warnings
+        run: cargo clippy --all-features --all-targets -- -D warnings
 
       # not all examples will build with the --manifest-path argument, since the
       # manifest-path argument will pull configuration from the current directory

examples/async-client-hello-callback/src/bin/quic_async_client_hello_callback_server.rs

@@ -64,7 +64,7 @@ impl ClientHelloCallback for ConfigCache {
             .cache
             .get_with(sni.clone(), || Arc::new(OnceCell::new()));
         if let Some(config) = once_cell_config.get() {
-            eprintln!("Config already cached for SNI: {}", sni);
+            eprintln!("Config already cached for SNI: {sni}");
             connection.set_config(config.clone())?;
             // return `None` if the Config is already in the cache
             return Ok(None);
@@ -84,7 +84,7 @@ impl ClientHelloCallback for ConfigCache {
                     return Err(S2nError::application(Box::new(CustomError)));
                 }
 
-                eprintln!("resolving certificate for SNI: {}", sni);
+                eprintln!("resolving certificate for SNI: {sni}");
 
                 // load the cert and key file asynchronously.
                 let (cert, key) = {

examples/event-framework/src/lib.rs

@@ -23,7 +23,7 @@ pub mod print_event {
             meta: &ConnectionMeta,
             info: &event::ConnectionInfo,
         ) -> Self::ConnectionContext {
-            println!("{:?} {:?}", meta, info);
+            println!("{meta:?} {info:?}");
         }
 
         /// This event fires for all events.
@@ -33,7 +33,7 @@ pub mod print_event {
             event: &E,
         ) {
             if self.print_all_events {
-                println!("event: {:?} {:?}", meta, event);
+                println!("event: {meta:?} {event:?}");
             }
         }
 
@@ -47,7 +47,7 @@ pub mod print_event {
             event: &E,
         ) {
             if self.print_connection_events {
-                println!("connection_event: {:?} {:?} {:?}", context, meta, event);
+                println!("connection_event: {context:?} {meta:?} {event:?}");
             }
         }
     }
@@ -110,7 +110,7 @@ pub mod query_event {
     impl Drop for MyQueryContext {
         // Execute some operations on the context before the Connection is dropped.
         fn drop(&mut self) {
-            println!("{:?}", self);
+            println!("{self:?}");
         }
     }
 }

examples/jumbo-frame/src/lib.rs

@@ -24,6 +24,6 @@ impl Subscriber for MtuEventInformer {
         _meta: &s2n_quic::provider::event::ConnectionMeta,
         event: &s2n_quic::provider::event::events::MtuUpdated,
     ) {
-        eprintln!("{:?}", event);
+        eprintln!("{event:?}");
     }
 }

examples/post-quantum/src/bin/pq_server.rs

@@ -35,7 +35,7 @@ async fn main() -> Result<(), Box<dyn Error>> {
 
                     // respond to the client with our own message
                     if let Ok(Some(data)) = stream.receive().await {
-                        eprintln!("message from the client: {:?}", data);
+                        eprintln!("message from the client: {data:?}");
                         let _ = stream.write_all(b"hello post-quantum client!\n").await;
                     }
                 });

examples/rustls-mtls/src/lib.rs

@@ -105,11 +105,11 @@ impl MtlsProvider {
 async fn read_file(path: &Path) -> Result<Vec<u8>, RustlsError> {
     let mut f = File::open(path)
         .await
-        .map_err(|e| RustlsError::General(format!("Failed to load file: {}", e)))?;
+        .map_err(|e| RustlsError::General(format!("Failed to load file: {e}")))?;
     let mut buf = Vec::new();
     f.read_to_end(&mut buf)
         .await
-        .map_err(|e| RustlsError::General(format!("Failed to read file: {}", e)))?;
+        .map_err(|e| RustlsError::General(format!("Failed to read file: {e}")))?;
     Ok(buf)
 }
 

examples/unreliable-datagram/src/bin/datagram_receiver.rs

@@ -58,9 +58,9 @@ async fn main() -> Result<(), Box<dyn Error>> {
         .await;
 
         match recv_result {
-            Ok(value) => eprintln!("RECV {:?}", value),
+            Ok(value) => eprintln!("RECV {value:?}"),
             Err(err) => {
-                eprintln!("{:?}", err);
+                eprintln!("{err:?}");
                 return Ok(());
             }
         }

examples/unreliable-datagram/src/bin/datagram_sender.rs

@@ -47,7 +47,7 @@ async fn main() -> Result<(), Box<dyn Error>> {
                             // The datagram was successfully inserted into the send queue
                         }
                         Err(err) => {
-                            eprintln!("{}", err);
+                            eprintln!("{err}");
                             // An error was encountered while calling the send_datagram
                             // method. Either the peer didn't advertise support for datagrams
                             // or the send queue is at capacity.

scripts/local_test

@@ -10,5 +10,5 @@
 set -e
 
 cargo +nightly fmt --all -- --check
-cargo +stable clippy --all-features --all-targets -- -D warnings -A clippy::derive_partial_eq_without_eq -A clippy::manual_clamp -A clippy::uninlined_format_args
+cargo +stable clippy --all-features --all-targets -- -D warnings
 cargo test