Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose lower level AF_XDP socket functions #2404

Closed
OliverGavin opened this issue Dec 6, 2024 · 0 comments · Fixed by #2405
Closed

Expose lower level AF_XDP socket functions #2404

OliverGavin opened this issue Dec 6, 2024 · 0 comments · Fixed by #2405

Comments

@OliverGavin
Copy link
Contributor

Problem:

Lower level AF_XDP socket functions are private and cannot be used directly (they are used within s2n).

Solution:

Make functions such as Channel::for_each public so they can be used without s2n specific layers above it.

The ask here is a short term solution until a wider effort is made to pull the lower level AF_XDP socket implementations into its own crate: #2403

  • Does this change what s2n-quic sends over the wire?
    • no
  • Does this change any public APIs? -->
    • not directly, but in migrating to it there will be changes

Requirements / Acceptance Criteria:

  • Related Issues:
  • Will the Usage Guide or other documentation need to be updated?
    • No, not until AF_XDP sock is offered as a stand alone crate?
  • Testing: How will this change be tested? Call out new integration tests, functional tests, or particularly interesting/important unit tests.
    • Scope is just making function public so additional testing should not be required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant