Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration port collisions #2127

Open
rday opened this issue Jul 13, 2020 · 0 comments
Open

Integration port collisions #2127

rday opened this issue Jul 13, 2020 · 0 comments

Comments

@rday
Copy link
Contributor

rday commented Jul 13, 2020

Problem:

xdist allows multiple workers to run integration tests. Each worker needs to have its own port range, or be sure that it is using a unique port at any given time. Otherwise we get errors when s2nd tries to bind to a port already in use.

Solution:

Assigning a unique port range, or grouping workers is the current approach- which breaks down when the number of workers exceeds 2. An alternatively, calling bind() with a port of zero will auto assign a random, available port should be an improvement, but will require a test framework refactor.

  • Does this change what S2N sends over the wire? No
  • Does this change any public APIs? No
  • Which versions of TLS will this impact? None

Requirements / Acceptance Criteria:

Multiple workers don't use the same port at the same time.

Out of scope:

Is there anything the solution will intentionally NOT address?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants