Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump minor version for rust bindings #4165

Closed
camshaft opened this issue Aug 24, 2023 · 2 comments
Closed

bump minor version for rust bindings #4165

camshaft opened this issue Aug 24, 2023 · 2 comments
Labels
priority/high Rank 2 s2n-core team size/small

Comments

@camshaft
Copy link
Contributor

Problem:

Publishing 0.0.X patch versions makes it difficult to consume for semver; which essentially assumes each patch is a major, breaking change.

Solution:

The version should be bumped to 0.1.0. Or 1.0.0 if we want to mark them as stable. That being said issues like #4131 should be fixed before that.
@camshaft camshaft mentioned this issue Aug 24, 2023
Closed
@goatgoose goatgoose mentioned this issue Sep 11, 2023
Merged
@lrstewart
Copy link
Contributor

We should do #4131 first

@jmayclin
Copy link
Contributor

This was completed in #4313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/high Rank 2 s2n-core team size/small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@camshaft @lrstewart @jmayclin @WesleyRosenblum @maddeleine